Create common mirror classes and populate I05s mirrors#1418
Create common mirror classes and populate I05s mirrors#1418
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
=======================================
Coverage 99.05% 99.06%
=======================================
Files 312 312
Lines 11750 11816 +66
=======================================
+ Hits 11639 11705 +66
Misses 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacob720
left a comment
jacob720
left a comment
There was a problem hiding this comment.
Looks good, one tiny comment, take it or leave it
|
Merge with main was not trivial - apologies, it's only structural changes, no change in device logic |
|
I should probably move common_mirror.py out of I05 - there might be beamlines with same mirrors that could reuse this code then easier. |
DominicOram
left a comment
DominicOram
left a comment
There was a problem hiding this comment.
Thanks, some comments in code. Didn't manage to get round to reviewing tests yet though, sorry
|
Sorry, this will need to be updated to comply with the new structure of dodal.devices.beamlines.iXX |
oliwenmandiamond
left a comment
oliwenmandiamond
left a comment
There was a problem hiding this comment.
This looks good. Thank you for making it comply with the new structure! Just minor formatting change and reuse the defaults and then happy to approve
5 participants
Fixes #1424
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}